Initial DB Domain Types #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcspragu
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM, though with comments on a few general patterns that I think we should figure out before adding more entities:
- Timestamp stuff (e.g.
created_atpopulated automatically per schema, usingCURRENT_TIMESTAMP, etc) - Using full domain structs for creation methods even when most fields are unused
exactlyOneandqueryversusqueryRowwhen querying on primary keys- Using
RunOrContinueTransactionin places with only a single SQL statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks in the initial schema for the PACTA app, as described first in the requirements, and then in the Schema Review. It also checks in the first ~10 pieces of
sqldbglue code to wire up + test our ability to persist and maniuplate the golang domain types. The first pieces chosen for this are first ones I need to implement the first piece of the site functionality, namely: managing initiative-user membership, which includes creating initiatives, users, invitations, and their acceptance flows.